Skip to content
  • Edouard CHIN's avatar
    4b803032
    Prevent persisting invalid record: · 4b803032
    Edouard CHIN authored
    - Fix #54267
    - In #53951, the goal was to allow saving a record and its association
      even if the association had existing invalid records in the DB.
      We would not validate the association in that case.
    
      The problem of not validating, is that it stops the validation
      chain and it's possible that other records in subsequent relations
      are being modified and are invalid.
      e.g. `Company -has_many-> Developers -has_many-> Computers`, if
      a computer is changed with invalid value and the company
      get saved, this would bypass the computer validation and persist it.
    
      This commit fixes that by ensuring there are no validation errors
      from *changed* records in the whole association chain.
    4b803032
    Prevent persisting invalid record:
    Edouard CHIN authored
    - Fix #54267
    - In #53951, the goal was to allow saving a record and its association
      even if the association had existing invalid records in the DB.
      We would not validate the association in that case.
    
      The problem of not validating, is that it stops the validation
      chain and it's possible that other records in subsequent relations
      are being modified and are invalid.
      e.g. `Company -has_many-> Developers -has_many-> Computers`, if
      a computer is changed with invalid value and the company
      get saved, this would bypass the computer validation and persist it.
    
      This commit fixes that by ensuring there are no validation errors
      from *changed* records in the whole association chain.
Loading