Skip to content
  • Behrokh Satarnejad's avatar
    8dec2503
    [43842] Re-design and small changes to modal dialogues (DS) for coherence (#11246) · 8dec2503
    Behrokh Satarnejad authored
    
    
    * wp deletion modal changes
    
    * fix test fails
    
    * invite user modal changes
    
    * fix eslint issus and add cancel button to summary modal
    
    * add widget modal changes
    
    * new board modal changes
    
    * form configuration modal changes and remove unnecessary class
    
    * WP table export modal changes
    
    * WP save query modal changes
    
    * visibility setting modal changes
    
    * help text modal changes
    
    * help video modal changes
    
    * 2FA password confimation modal changes
    
    * Delete EE token modal changes
    
    * fix eslint errors
    
    * eslint does not check the unbound method
    
    * minor changes to switch the buttons and icon
    
    * fix specs failing for invite user modal changes
    
    * use the correct translations and revert the previous merge
    
    * Fix opAutofocus directive
    
    The opAutofocus directive was not setting focus if used like a normal
    `autofocus` HTML attribute:
    
    ```
    <input opAutofocus />
    ```
    
    The above example would not produce a focus, because counterintuitively
    Angular treats the default input to the directive here as an empty
    string instead of undefined. This causes the default value of `true` NOT
    to be set. Instead, the empty string was treated like the falsy value
    it is.
    
    * add focus on invite user modal while opening
    
    * fix eslint errors
    
    * eslint errors fix
    
    * add icon delete for deleting ee token
    
    * wp delete modal changes: remove unnecessary loading and change op-icon to a span
    
    * remove unused components
    
    * use spot-list for add-widget modal
    
    * wp table configuration modal changes
    
    * fix finding list item in add widget modal specs
    
    * Chore/modal spacing (#11314)
    
    * [chore] reworked spot-container spacings
    
    * [chore] applied spot-container to spot-modal--body
    
    - added style override for spacing within modal body
    
    * [chore] removed unused modal footer class
    
    * Remove scrollbar from project-include
    
    Project include was creating scrollbars for the project list even if
    it was not needed. This was caused by tooltips that were hidden in the
    background but still affecting layouting.
    
    This commit hides the tooltips correctly, and aligns the HTML structure
    of project include to match that of file link list. A minimum height is
    added to the project include list to make sure tooltips are readable even
    if there is only one item in the list.
    
    * [chore] rework of datepicker modal
    
    - changed spacings, removed inner margins
    - changed anchors to buttons (spot-link)
    - added flatpickr override
    - removed min-height
    - moved project include min-height to root element
    
    * [chore] fixed test selector
    
    Co-authored-by: default avatarBenjamin Bädorf <b.baedorf@openproject.com>
    
    * redesign the save query modal changes
    
    * remove op-form class from invite user modal since we have spot-container now
    
    * add text and title for ee modal deletion
    
    * showing the error message when it is not valid value in invite user modal
    
    * close the inroduction video modal  with button
    
    * close the dynamic content modal without jquery
    
    * fx eslint warnnings
    
    * webhook response modal
    
    * remove multiple cancel translation in invite user modal
    
    * fix indentation in html file
    
    Co-authored-by: default avatarBenjamin Bädorf <b.baedorf@openproject.com>
    Co-authored-by: default avatarEric Schubert <38206611+Kharonus@users.noreply.github.com>
    8dec2503
    [43842] Re-design and small changes to modal dialogues (DS) for coherence (#11246)
    Behrokh Satarnejad authored
    
    
    * wp deletion modal changes
    
    * fix test fails
    
    * invite user modal changes
    
    * fix eslint issus and add cancel button to summary modal
    
    * add widget modal changes
    
    * new board modal changes
    
    * form configuration modal changes and remove unnecessary class
    
    * WP table export modal changes
    
    * WP save query modal changes
    
    * visibility setting modal changes
    
    * help text modal changes
    
    * help video modal changes
    
    * 2FA password confimation modal changes
    
    * Delete EE token modal changes
    
    * fix eslint errors
    
    * eslint does not check the unbound method
    
    * minor changes to switch the buttons and icon
    
    * fix specs failing for invite user modal changes
    
    * use the correct translations and revert the previous merge
    
    * Fix opAutofocus directive
    
    The opAutofocus directive was not setting focus if used like a normal
    `autofocus` HTML attribute:
    
    ```
    <input opAutofocus />
    ```
    
    The above example would not produce a focus, because counterintuitively
    Angular treats the default input to the directive here as an empty
    string instead of undefined. This causes the default value of `true` NOT
    to be set. Instead, the empty string was treated like the falsy value
    it is.
    
    * add focus on invite user modal while opening
    
    * fix eslint errors
    
    * eslint errors fix
    
    * add icon delete for deleting ee token
    
    * wp delete modal changes: remove unnecessary loading and change op-icon to a span
    
    * remove unused components
    
    * use spot-list for add-widget modal
    
    * wp table configuration modal changes
    
    * fix finding list item in add widget modal specs
    
    * Chore/modal spacing (#11314)
    
    * [chore] reworked spot-container spacings
    
    * [chore] applied spot-container to spot-modal--body
    
    - added style override for spacing within modal body
    
    * [chore] removed unused modal footer class
    
    * Remove scrollbar from project-include
    
    Project include was creating scrollbars for the project list even if
    it was not needed. This was caused by tooltips that were hidden in the
    background but still affecting layouting.
    
    This commit hides the tooltips correctly, and aligns the HTML structure
    of project include to match that of file link list. A minimum height is
    added to the project include list to make sure tooltips are readable even
    if there is only one item in the list.
    
    * [chore] rework of datepicker modal
    
    - changed spacings, removed inner margins
    - changed anchors to buttons (spot-link)
    - added flatpickr override
    - removed min-height
    - moved project include min-height to root element
    
    * [chore] fixed test selector
    
    Co-authored-by: default avatarBenjamin Bädorf <b.baedorf@openproject.com>
    
    * redesign the save query modal changes
    
    * remove op-form class from invite user modal since we have spot-container now
    
    * add text and title for ee modal deletion
    
    * showing the error message when it is not valid value in invite user modal
    
    * close the inroduction video modal  with button
    
    * close the dynamic content modal without jquery
    
    * fx eslint warnnings
    
    * webhook response modal
    
    * remove multiple cancel translation in invite user modal
    
    * fix indentation in html file
    
    Co-authored-by: default avatarBenjamin Bädorf <b.baedorf@openproject.com>
    Co-authored-by: default avatarEric Schubert <38206611+Kharonus@users.noreply.github.com>
Loading