Skip to content
  • Hiroshi SHIBATA's avatar
    9ae91eb2
    Backport warning feature for bundled gems from master (#11420) · 9ae91eb2
    Hiroshi SHIBATA authored
    
    
    * Make sure to always use the right `warn`
    
    * lib/bundled_gems.rb: more reliable caller detection
    
    The `2` skipped frames went out of sync and now it should be `3`.
    
    Rather than just update the offset, we can implement a way that
    is adaptative as long as all require decorators are also called require.
    
    Also we should compute the corresponding `uplevel` otherwise the
    warning will still point decorators.
    
    Co-authored-by: default avatar"Hiroshi SHIBATA" <hsbt@ruby-lang.org>
    
    * Warn ostruct for Ruby 3.5
    
    * Warn pstore for Ruby 3.5
    
    * Mark rdoc as bundled gems at Ruby 3.5
    
    * Warn to use win32ole without Gemfile for Ruby 3.5
    
    * EXACT list is mostly same as SINCE list on bundled gems.
    
    * Mark to warn fiddle as bundled gems for Ruby 3.5
    
    * Mark to warn logger as bundled gems for Ruby 3.5
    
    * We should use uplevel:2 in another case.
    
    Like the following scenario with bootsnap, that frames are same or smaller than frame_to_skip(=3).
    
    ---
    "/Users/hsbt/.local/share/rbenv/versions/3.3-dev/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'"
    "/Users/hsbt/.local/share/gem/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'"
    "test_warn_bootsnap.rb:11:in `<main>'"
    ---
    
    * Delete unnecessary rubocop disable comment
    
    * Show correct script name with sub-feature case
    
    * Skip to show script name with using ruby -r option
    
    * Don't show script name when bundle exec and call ruby script directly.
    
    * Pick word fix from 34adc073
    
    ---------
    
    Co-authored-by: default avatarDavid Rodríguez <deivid.rodriguez@riseup.net>
    Co-authored-by: default avatarJean Boussier <jean.boussier@gmail.com>
    Co-authored-by: default avatarKentaro Takeyama <75117116+obregonia1@users.noreply.github.com>
    9ae91eb2
    Backport warning feature for bundled gems from master (#11420)
    Hiroshi SHIBATA authored
    
    
    * Make sure to always use the right `warn`
    
    * lib/bundled_gems.rb: more reliable caller detection
    
    The `2` skipped frames went out of sync and now it should be `3`.
    
    Rather than just update the offset, we can implement a way that
    is adaptative as long as all require decorators are also called require.
    
    Also we should compute the corresponding `uplevel` otherwise the
    warning will still point decorators.
    
    Co-authored-by: default avatar"Hiroshi SHIBATA" <hsbt@ruby-lang.org>
    
    * Warn ostruct for Ruby 3.5
    
    * Warn pstore for Ruby 3.5
    
    * Mark rdoc as bundled gems at Ruby 3.5
    
    * Warn to use win32ole without Gemfile for Ruby 3.5
    
    * EXACT list is mostly same as SINCE list on bundled gems.
    
    * Mark to warn fiddle as bundled gems for Ruby 3.5
    
    * Mark to warn logger as bundled gems for Ruby 3.5
    
    * We should use uplevel:2 in another case.
    
    Like the following scenario with bootsnap, that frames are same or smaller than frame_to_skip(=3).
    
    ---
    "/Users/hsbt/.local/share/rbenv/versions/3.3-dev/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'"
    "/Users/hsbt/.local/share/gem/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'"
    "test_warn_bootsnap.rb:11:in `<main>'"
    ---
    
    * Delete unnecessary rubocop disable comment
    
    * Show correct script name with sub-feature case
    
    * Skip to show script name with using ruby -r option
    
    * Don't show script name when bundle exec and call ruby script directly.
    
    * Pick word fix from 34adc073
    
    ---------
    
    Co-authored-by: default avatarDavid Rodríguez <deivid.rodriguez@riseup.net>
    Co-authored-by: default avatarJean Boussier <jean.boussier@gmail.com>
    Co-authored-by: default avatarKentaro Takeyama <75117116+obregonia1@users.noreply.github.com>
Loading