Skip to content
  • Yusuke Endoh's avatar
    b957c3db
    [rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix · b957c3db
    Yusuke Endoh authored
    This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
    and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
    
    The two files are a helper for tests, not test files. However, a file
    starting with "test_" prefix is handled as a test file directly loaded
    by test-unit because Rakefile specifies:
    
    ```
    t.test_files = FileList['test/**/test_*.rb']
    ```
    
    Directly loading test/rubygems/test_utilities.rb caused "uninitialized
    constant Gem::TestCase". This issue was fixed by
    59c68209, but the fix caused a
    "circular require" warning because test_utilities.rb and test_case.rb
    are now requiring each other.
    
    Anyway, adding "test_" prefix to a test helper file is confusing, so
    this changeset reverts the fix and solve the issue by renaming them.
    
    https://github.com/rubygems/rubygems/commit/6460e018df
    b957c3db
    [rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix
    Yusuke Endoh authored
    This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
    and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
    
    The two files are a helper for tests, not test files. However, a file
    starting with "test_" prefix is handled as a test file directly loaded
    by test-unit because Rakefile specifies:
    
    ```
    t.test_files = FileList['test/**/test_*.rb']
    ```
    
    Directly loading test/rubygems/test_utilities.rb caused "uninitialized
    constant Gem::TestCase". This issue was fixed by
    59c68209, but the fix caused a
    "circular require" warning because test_utilities.rb and test_case.rb
    are now requiring each other.
    
    Anyway, adding "test_" prefix to a test helper file is confusing, so
    this changeset reverts the fix and solve the issue by renaming them.
    
    https://github.com/rubygems/rubygems/commit/6460e018df
Loading