Skip to content
  • David Rodríguez's avatar
    5a384e2c
    Fix some bundler specs (#2380) · 5a384e2c
    David Rodríguez authored
    * These seem to consistenly pass already
    
    * Show actual command when running `make test-bundler`
    
    Current the setup command that installs the necessary gems for testing
    bundler was printed, but not the actual command that runs the tests.
    That was a bit confusing.
    
    * Borrow trick from setproctitle specs
    
    * A title that long doesn't get set sometimes
    
    No idea why, but the test doesn't need that the title is that long.
    
    * Fix most gem helper spec ruby-core failures
    
    * Fix the rest of the gem helper failures
    
    * Fix version spec by improving the assertion
    
    * Remove unnecessary `BUNDLE_RUBY` environment var
    
    We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
    because bundler considers `BUNDLE_*` variables as settings.
    
    * Rename `BUNDLE_GEM` to `GEM_COMMAND`
    
    This is more descriptive I think, and also friendlier for bundler
    because `BUNDLE_` env variables are interpreted by bundler as settings,
    and this is not a bundler setting.
    
    This fixes one bundler spec failure in config specs against ruby-core.
    
    * Fix quality spec when run in core
    
    Use the proper path helper.
    
    * Fix dummy lib builder to never load default gems
    
    If a dummy library is named as a default gem, when requiring the library
    from its executable, the default gem would be loaded when running from
    core, because in core all default gems share path with bundler, and thus
    they are always in the $LOAD_PATH. We fix the issue by loading lib
    relatively inside dummy lib executables.
    
    * More exact assertions
    
    Sometimes I have the problem that I do some "print debugging" inside
    specs, and suddently the spec passes. This happens when the assertion is
    too relaxed, and the things I print make it match, specially when they
    are simple strings like "1.0" than can be easily be part of gem paths
    that I print for debugging.
    
    I fix this by making a more exact assertion.
    
    * Detect the correct shebang when ENV["RUBY"] is set
    
    * Relax assertion
    
    So that the spec passes even if another paths containing "ext" are in
    the load path. This works to fix a ruby-core issue, but it's a better
    assertion in general. We just want to know that the extension path was
    added.
    
    * Use folder structure independent path helper
    
    It should fix this spec for ruby-core.
    
    * Fix the last failing spec on ruby-core
    
    * Skip `bundle open <default_gem>` spec when no default gems
    5a384e2c
    Fix some bundler specs (#2380)
    David Rodríguez authored
    * These seem to consistenly pass already
    
    * Show actual command when running `make test-bundler`
    
    Current the setup command that installs the necessary gems for testing
    bundler was printed, but not the actual command that runs the tests.
    That was a bit confusing.
    
    * Borrow trick from setproctitle specs
    
    * A title that long doesn't get set sometimes
    
    No idea why, but the test doesn't need that the title is that long.
    
    * Fix most gem helper spec ruby-core failures
    
    * Fix the rest of the gem helper failures
    
    * Fix version spec by improving the assertion
    
    * Remove unnecessary `BUNDLE_RUBY` environment var
    
    We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
    because bundler considers `BUNDLE_*` variables as settings.
    
    * Rename `BUNDLE_GEM` to `GEM_COMMAND`
    
    This is more descriptive I think, and also friendlier for bundler
    because `BUNDLE_` env variables are interpreted by bundler as settings,
    and this is not a bundler setting.
    
    This fixes one bundler spec failure in config specs against ruby-core.
    
    * Fix quality spec when run in core
    
    Use the proper path helper.
    
    * Fix dummy lib builder to never load default gems
    
    If a dummy library is named as a default gem, when requiring the library
    from its executable, the default gem would be loaded when running from
    core, because in core all default gems share path with bundler, and thus
    they are always in the $LOAD_PATH. We fix the issue by loading lib
    relatively inside dummy lib executables.
    
    * More exact assertions
    
    Sometimes I have the problem that I do some "print debugging" inside
    specs, and suddently the spec passes. This happens when the assertion is
    too relaxed, and the things I print make it match, specially when they
    are simple strings like "1.0" than can be easily be part of gem paths
    that I print for debugging.
    
    I fix this by making a more exact assertion.
    
    * Detect the correct shebang when ENV["RUBY"] is set
    
    * Relax assertion
    
    So that the spec passes even if another paths containing "ext" are in
    the load path. This works to fix a ruby-core issue, but it's a better
    assertion in general. We just want to know that the extension path was
    added.
    
    * Use folder structure independent path helper
    
    It should fix this spec for ruby-core.
    
    * Fix the last failing spec on ruby-core
    
    * Skip `bundle open <default_gem>` spec when no default gems
Loading