Skip to content
  • nagachika's avatar
    a8598255
    merge revision(s)... · a8598255
    nagachika authored
    merge revision(s) 276f6a22,95bef7b6: [Backport #17352]
    
    	Don't double fractional seconds when passing timezone object to
    	 Time.new
    
    	I found that fractional seconds were doubled when using the timezone
    	feature of Time in Sequel's named_timezones extension (which uses
    	TZInfo for the timezone object), and traced the problem to this code.
    
    	There is no subsecx being modified in the utc_to_local call below
    	this, and I'm not sure why you would want to add in the fractional
    	seconds unless you assumed the timezone conversion would drop the
    	existing fractional seconds (TZInfo doesn't drop fractional seconds).
    	---
    	 test/ruby/test_time_tz.rb | 10 ++++++++++
    	 1 file changed, 10 insertions(+)
    
    	Subsecond of Time::tm should be 0
    
    	---
    	 time.c | 1 +
    	 1 file changed, 1 insertion(+)
    a8598255
    merge revision(s)...
    nagachika authored
    merge revision(s) 276f6a22,95bef7b6: [Backport #17352]
    
    	Don't double fractional seconds when passing timezone object to
    	 Time.new
    
    	I found that fractional seconds were doubled when using the timezone
    	feature of Time in Sequel's named_timezones extension (which uses
    	TZInfo for the timezone object), and traced the problem to this code.
    
    	There is no subsecx being modified in the utc_to_local call below
    	this, and I'm not sure why you would want to add in the fractional
    	seconds unless you assumed the timezone conversion would drop the
    	existing fractional seconds (TZInfo doesn't drop fractional seconds).
    	---
    	 test/ruby/test_time_tz.rb | 10 ++++++++++
    	 1 file changed, 10 insertions(+)
    
    	Subsecond of Time::tm should be 0
    
    	---
    	 time.c | 1 +
    	 1 file changed, 1 insertion(+)
Loading