Skip to content
  • Alan Wu's avatar
    f5d20411
    Avoid assert failure when NULL EC is expected · f5d20411
    Alan Wu authored
    
    
    After 5680c38c, postponed job APIs now
    expect to be called on native threads not managed by Ruby and handles
    getting a NULL execution context. However, in debug builds the change
    runs into an assertion failure with GET_EC() which asserts that EC is
    non-NULL. Avoid the assertion failure by passing `false` for `expect_ec`
    instead as the intention is to handle when there is no EC.
    
    Add a test from John Crepezzi and John Hawthorn to exercise this
    situation.
    
    See GH-4108
    See GH-5094
    
    [Bug #17573]
    
    Co-authored-by: default avatarJohn Hawthorn <john@hawthorn.email>
    Co-authored-by: default avatarJohn Crepezzi <john.crepezzi@gmail.com>
    f5d20411
    Avoid assert failure when NULL EC is expected
    Alan Wu authored
    
    
    After 5680c38c, postponed job APIs now
    expect to be called on native threads not managed by Ruby and handles
    getting a NULL execution context. However, in debug builds the change
    runs into an assertion failure with GET_EC() which asserts that EC is
    non-NULL. Avoid the assertion failure by passing `false` for `expect_ec`
    instead as the intention is to handle when there is no EC.
    
    Add a test from John Crepezzi and John Hawthorn to exercise this
    situation.
    
    See GH-4108
    See GH-5094
    
    [Bug #17573]
    
    Co-authored-by: default avatarJohn Hawthorn <john@hawthorn.email>
    Co-authored-by: default avatarJohn Crepezzi <john.crepezzi@gmail.com>
Loading