Skip to content
  • Jason Karns's avatar
    21494ba3
    Remove suite-wide setup · 21494ba3
    Jason Karns authored
    Bats doesn't support both suite-wide setup (in helper) *and* file-wide
    setup. Which means the existance of any file-level setup() function
    overwrites any setup() function from test_helper. This can be confusing,
    and (IMO) easier to simply avoid the overwriting and remove any
    _implied_ suite-wide setup function from test_helper.
    
    This turns out to not be so bad for the recently added setup function,
    because the only test files that actually need aria2c removed from PATH
    are those that actually invoke curl. These can be found because they are
    the only test files that stub curl; half of which already had
    file-specific setup() functions. So the only ones which need a
    file-local setup() function added were: checksum.bats and mirror.bats
    
    Along these lines, rbenv.bats and hooks.bats were removing aria2c from
    PATH but don't actually need to. (curl isn't stubbed in these tests so
    the existance of aria2c wouldn't affect the tests)
    
    Lastly, fixed a tab/spaces whitespace mixup that was introduced by:
    750c086d
    21494ba3
    Remove suite-wide setup
    Jason Karns authored
    Bats doesn't support both suite-wide setup (in helper) *and* file-wide
    setup. Which means the existance of any file-level setup() function
    overwrites any setup() function from test_helper. This can be confusing,
    and (IMO) easier to simply avoid the overwriting and remove any
    _implied_ suite-wide setup function from test_helper.
    
    This turns out to not be so bad for the recently added setup function,
    because the only test files that actually need aria2c removed from PATH
    are those that actually invoke curl. These can be found because they are
    the only test files that stub curl; half of which already had
    file-specific setup() functions. So the only ones which need a
    file-local setup() function added were: checksum.bats and mirror.bats
    
    Along these lines, rbenv.bats and hooks.bats were removing aria2c from
    PATH but don't actually need to. (curl isn't stubbed in these tests so
    the existance of aria2c wouldn't affect the tests)
    
    Lastly, fixed a tab/spaces whitespace mixup that was introduced by:
    750c086d
Loading