Skip to content
  • Anup Narkhede's avatar
    3d7b5217
    Fix VideoAnalyzerTest#test_analyzing_a_rotated_HDR_video failure with ffmpeg < 5.0 · 3d7b5217
    Anup Narkhede authored
    The VideoAnalyzer uses ffprobe (part of ffmpeg) to determine the
    rotation of a video. The VideoAnalyzer#angle returns tags["rotate"] if
    it is available, else it attempts to get "rotation" from the Display
    Matrix side_data.
    
    However, ffprobe exhibits different behavior with different versions:
    ffprobe version 4.4.2-0ubuntu on Ubuntu 22.04 returns a "rotate" : "90"
    tag.
    
    In contrast, ffprobe version 6.0-6ubuntu1 on Ubuntu 23.10 does not
    return the "rotate" tag; instead, it determines the angle from the
    display matrix side_data, which returns "rotation": -90.
    
    To account for this difference, we now check for both values in the test.
    3d7b5217
    Fix VideoAnalyzerTest#test_analyzing_a_rotated_HDR_video failure with ffmpeg < 5.0
    Anup Narkhede authored
    The VideoAnalyzer uses ffprobe (part of ffmpeg) to determine the
    rotation of a video. The VideoAnalyzer#angle returns tags["rotate"] if
    it is available, else it attempts to get "rotation" from the Display
    Matrix side_data.
    
    However, ffprobe exhibits different behavior with different versions:
    ffprobe version 4.4.2-0ubuntu on Ubuntu 22.04 returns a "rotate" : "90"
    tag.
    
    In contrast, ffprobe version 6.0-6ubuntu1 on Ubuntu 23.10 does not
    return the "rotate" tag; instead, it determines the angle from the
    display matrix side_data, which returns "rotation": -90.
    
    To account for this difference, we now check for both values in the test.
Loading