Skip to content
  • zzak's avatar
    833c1c9a
    Enable Lint/Debugger · 833c1c9a
    zzak authored
    This will prevent issues like be0cb4e8, which would have resulted in:
    
    ```
    guides/rails_guides/generator.rb:16:1: W: Lint/Debugger: Remove debugger entry point require "debug".
    require "debug"
    ^^^^^^^^^^^^^^^
    ```
    
    Disabled the cop in actionpack tests for screenshot_helper and page_dump_helper:
    
    ```
    actionpack/test/controller/integration_test.rb:1369:9: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
            save_and_open_page
            ^^^^^^^^^^^^^^^^^^
    actionpack/test/controller/integration_test.rb:1381:11: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
              save_and_open_page
              ^^^^^^^^^^^^^^^^^^
    actionpack/test/controller/integration_test.rb:1391:39: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
          assert_raise(InvalidResponse) { save_and_open_page }
                                          ^^^^^^^^^^^^^^^^^^
    ```
    
    ```
    actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb:111:13: W: Lint/Debugger: Remove debugger entry point page.save_page(absolute_html_path).
                page.save_page(absolute_html_path)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb:115:13: W: Lint/Debugger: Remove debugger entry point page.save_screenshot(absolute_image
    _path).
                page.save_screenshot(absolute_image_path)
    ```
    
    The DebuggerRequires option was first available in rubocop v1.63.0, in rubocop/rubocop#12766.
    833c1c9a
    Enable Lint/Debugger
    zzak authored
    This will prevent issues like be0cb4e8, which would have resulted in:
    
    ```
    guides/rails_guides/generator.rb:16:1: W: Lint/Debugger: Remove debugger entry point require "debug".
    require "debug"
    ^^^^^^^^^^^^^^^
    ```
    
    Disabled the cop in actionpack tests for screenshot_helper and page_dump_helper:
    
    ```
    actionpack/test/controller/integration_test.rb:1369:9: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
            save_and_open_page
            ^^^^^^^^^^^^^^^^^^
    actionpack/test/controller/integration_test.rb:1381:11: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
              save_and_open_page
              ^^^^^^^^^^^^^^^^^^
    actionpack/test/controller/integration_test.rb:1391:39: W: Lint/Debugger: Remove debugger entry point save_and_open_page.
          assert_raise(InvalidResponse) { save_and_open_page }
                                          ^^^^^^^^^^^^^^^^^^
    ```
    
    ```
    actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb:111:13: W: Lint/Debugger: Remove debugger entry point page.save_page(absolute_html_path).
                page.save_page(absolute_html_path)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb:115:13: W: Lint/Debugger: Remove debugger entry point page.save_screenshot(absolute_image
    _path).
                page.save_screenshot(absolute_image_path)
    ```
    
    The DebuggerRequires option was first available in rubocop v1.63.0, in rubocop/rubocop#12766.
Loading