Skip to content
  • Edouard CHIN's avatar
    859f3bf0
    Deprecate custom Action Mailer delivery job: · 859f3bf0
    Edouard CHIN authored
    - Action Mailer delivery job should modify their `perform` method
      signature in order to receive the new payload that Action Mailer
      sends.
    
      Before:
    
      ```ruby
        def perform(mailer, mail_method, delivery_method, *args)
        end
      ```
    
      After:
    
      ```ruby
        def perform(mailer, mail_method, delivery_method, args:)
        end
      ```
    
      This new behaviour was introduced couple years ago in a attempt to
      get rid of the necessity to have a different job for paramterized
      mailers. A deprecation was introduced for custom jobs inheriting
      from `ActionMailer::DeliveryJob` but for jobs that didn't it went
      unnoticed.
      The deprecated behaviour was supposed to be removed in Rails 6.1
      but we couldn't and it got reverted https://github.com/rails/rails/pull/39257
    859f3bf0
    Deprecate custom Action Mailer delivery job:
    Edouard CHIN authored
    - Action Mailer delivery job should modify their `perform` method
      signature in order to receive the new payload that Action Mailer
      sends.
    
      Before:
    
      ```ruby
        def perform(mailer, mail_method, delivery_method, *args)
        end
      ```
    
      After:
    
      ```ruby
        def perform(mailer, mail_method, delivery_method, args:)
        end
      ```
    
      This new behaviour was introduced couple years ago in a attempt to
      get rid of the necessity to have a different job for paramterized
      mailers. A deprecation was introduced for custom jobs inheriting
      from `ActionMailer::DeliveryJob` but for jobs that didn't it went
      unnoticed.
      The deprecated behaviour was supposed to be removed in Rails 6.1
      but we couldn't and it got reverted https://github.com/rails/rails/pull/39257
Loading