Skip to content
  • Prathamesh Sonpatki's avatar
    8b77d8e3
    Fix prepared statements disabled test again · 8b77d8e3
    Prathamesh Sonpatki authored
    - Due to `assert_nothing_raised` this test was not really testing
      anything.
    - So updated it to assert that the query gives expected result.
    - Also in general we can use `connection.unprepared_statement` for
      testing queries w/o prepared statements but it can't be used in this
      case. This test cases was added because when prepared_statements
      config is set to false, then DetermineIfPreparableVisitor module
      does not extended by Arel visitor resulting into an error. Ref: https://github.com/rails/rails/pull/22748.
    - Because DetermineIfPreparableVisitor module does not get added to the
      visitor chain only if prepared_statements is false while **setting up
      connection**, not when `unprepared_statement` is used.
    - I have also added an assertion for making sure that prepared_config
      is set to false from the start, so that nobody accidentally removes
      the connection setup using `arunit_without_prepared_statements` and
      replaces it with stubs or unprepared_statement.
    8b77d8e3
    Fix prepared statements disabled test again
    Prathamesh Sonpatki authored
    - Due to `assert_nothing_raised` this test was not really testing
      anything.
    - So updated it to assert that the query gives expected result.
    - Also in general we can use `connection.unprepared_statement` for
      testing queries w/o prepared statements but it can't be used in this
      case. This test cases was added because when prepared_statements
      config is set to false, then DetermineIfPreparableVisitor module
      does not extended by Arel visitor resulting into an error. Ref: https://github.com/rails/rails/pull/22748.
    - Because DetermineIfPreparableVisitor module does not get added to the
      visitor chain only if prepared_statements is false while **setting up
      connection**, not when `unprepared_statement` is used.
    - I have also added an assertion for making sure that prepared_config
      is set to false from the start, so that nobody accidentally removes
      the connection setup using `arunit_without_prepared_statements` and
      replaces it with stubs or unprepared_statement.
Loading