Skip to content
  • Rafael Mendonça França's avatar
    33db4216
    Revert "Merge pull request #27775 from domcleal/27774-format-reset" · 33db4216
    Rafael Mendonça França authored
    This reverts commit c6f9f8c2, reversing
    changes made to c309073c.
    
    Reason: This is fixing the behavior in the wrong place. Now the request
    path after the request is nil and there is no way to assert that.
    Also the test that was added in that PR also fails in 4.2 where the
    reporter says it was passing. The reason the bahavior changed between
    Rails 4.2 and Rails 5 is that the format in the path is now respected.
    The correct way to fix the problem is not doign two requests in the same
    controller test and use integrations tests. This change caused a
    regression between Rails 5.0.1 and 5.0.2.
    33db4216
    Revert "Merge pull request #27775 from domcleal/27774-format-reset"
    Rafael Mendonça França authored
    This reverts commit c6f9f8c2, reversing
    changes made to c309073c.
    
    Reason: This is fixing the behavior in the wrong place. Now the request
    path after the request is nil and there is no way to assert that.
    Also the test that was added in that PR also fails in 4.2 where the
    reporter says it was passing. The reason the bahavior changed between
    Rails 4.2 and Rails 5 is that the format in the path is now respected.
    The correct way to fix the problem is not doign two requests in the same
    controller test and use integrations tests. This change caused a
    regression between Rails 5.0.1 and 5.0.2.
Loading