Skip to content
  • Sean Griffin's avatar
    197789da
    Correctly handle limit on int4 and int8 types in PG · 197789da
    Sean Griffin authored
    PG doesn't register it's types using the `int(4)` format that others do.
    As such, if we alias `int8` to the other integer types, the range
    information is lost. This is fixed by simply registering it separately.
    
    The other option (which I specifically chose to avoid) is to pass the
    information of the original type that was being aliased as an argument.
    I'd rather avoid that, since an alias should truly be treated the same.
    If we need different behavior for a different type, we should explicitly
    register it with that, and not have a conditional based on aliasing.
    
    Fixes #18144
    
    [Sean Griffin & ysbaddaden]
    197789da
    Correctly handle limit on int4 and int8 types in PG
    Sean Griffin authored
    PG doesn't register it's types using the `int(4)` format that others do.
    As such, if we alias `int8` to the other integer types, the range
    information is lost. This is fixed by simply registering it separately.
    
    The other option (which I specifically chose to avoid) is to pass the
    information of the original type that was being aliased as an argument.
    I'd rather avoid that, since an alias should truly be treated the same.
    If we need different behavior for a different type, we should explicitly
    register it with that, and not have a conditional based on aliasing.
    
    Fixes #18144
    
    [Sean Griffin & ysbaddaden]
Loading