Skip to content
  • Godfrey Chan's avatar
    1f161360
    Deprecated Numeric#{ago,until,since,from_now} · 1f161360
    Godfrey Chan authored
    The user is expected to explicitly convert the value into an
    AS::Duration, i.e. `5.ago` => `5.seconds.ago`
    
    This will help to catch subtle bugs like:
    
      def recent?(days = 3)
        self.created_at >= days.ago
      end
    
    The above code would check if the model is created within the last 3
    **seconds**.
    
    In the future, `Numeric#{ago,until,since,from_now}` should be removed
    completely, or throw some sort of errors to indicate there are no
    implicit conversion from `Numeric` to `AS::Duration`.
    
    Also fixed & refactor the test cases for Numeric#{ago,since} and
    AS::Duration#{ago,since}. The original test case had the assertion
    flipped and the purpose of the test wasn't very clear.
    1f161360
    Deprecated Numeric#{ago,until,since,from_now}
    Godfrey Chan authored
    The user is expected to explicitly convert the value into an
    AS::Duration, i.e. `5.ago` => `5.seconds.ago`
    
    This will help to catch subtle bugs like:
    
      def recent?(days = 3)
        self.created_at >= days.ago
      end
    
    The above code would check if the model is created within the last 3
    **seconds**.
    
    In the future, `Numeric#{ago,until,since,from_now}` should be removed
    completely, or throw some sort of errors to indicate there are no
    implicit conversion from `Numeric` to `AS::Duration`.
    
    Also fixed & refactor the test cases for Numeric#{ago,since} and
    AS::Duration#{ago,since}. The original test case had the assertion
    flipped and the purpose of the test wasn't very clear.
Loading