Skip to content
  • Yasuo Honda's avatar
    3d1a879f
    Ignore binds payload with nil column in AR log subscriber · 3d1a879f
    Yasuo Honda authored
    Some tests were raising the following error:
    
        Could not log "sql.active_record" event. NoMethodError: undefined method
        `type' for nil:NilClass`
    
    Due to the way binds were being logged, the column info was considered
    always present, but that is not true for some of the tests listed in the
    issue.
    
    Closes #8806.
    
    Conflicts:
    
    	activerecord/lib/active_record/log_subscriber.rb
    	activerecord/test/cases/log_subscriber_test.rb
    
    Conflict resolution:
    - Revert ruby 1.9 style hash to support ruby 1.8
    - Do not include 8f59ffce into 3-2-stable
    3d1a879f
    Ignore binds payload with nil column in AR log subscriber
    Yasuo Honda authored
    Some tests were raising the following error:
    
        Could not log "sql.active_record" event. NoMethodError: undefined method
        `type' for nil:NilClass`
    
    Due to the way binds were being logged, the column info was considered
    always present, but that is not true for some of the tests listed in the
    issue.
    
    Closes #8806.
    
    Conflicts:
    
    	activerecord/lib/active_record/log_subscriber.rb
    	activerecord/test/cases/log_subscriber_test.rb
    
    Conflict resolution:
    - Revert ruby 1.9 style hash to support ruby 1.8
    - Do not include 8f59ffce into 3-2-stable
Loading