Skip to content
  • Edouard CHIN's avatar
    40cb50e0
    Fix the BroadcastLogger being initialized too late: · 40cb50e0
    Edouard CHIN authored
    - An oversight of #48615 is that it changes the `Rails.logger` to be
      a broadcast logger after the app is booted. Anything referencing
      `Rails.logger` during the boot process will get a simple logger and
      ultimately resulting in logs not being broadcasted.
    
      For example `ActionController::Base.logger.info("abc")` would
      just output logs in the `development.log` file, not on STDOUT.
    
      ----
    
      The only solution I could think of is to create a BroadcastLogger
      earlier at boot, and add logger to that broadcast when needed (instead
      of modiyfing the `Rails.logger` variable).
    40cb50e0
    Fix the BroadcastLogger being initialized too late:
    Edouard CHIN authored
    - An oversight of #48615 is that it changes the `Rails.logger` to be
      a broadcast logger after the app is booted. Anything referencing
      `Rails.logger` during the boot process will get a simple logger and
      ultimately resulting in logs not being broadcasted.
    
      For example `ActionController::Base.logger.info("abc")` would
      just output logs in the `development.log` file, not on STDOUT.
    
      ----
    
      The only solution I could think of is to create a BroadcastLogger
      earlier at boot, and add logger to that broadcast when needed (instead
      of modiyfing the `Rails.logger` variable).
Loading