Skip to content
  • Rafael Mendonça França's avatar
    561fa1e1
    Revert "Add ActiveRecord::Base.connection.with_advisory_lock" · 561fa1e1
    Rafael Mendonça França authored
    This reverts commit 1ab4dbf8.
    
    After speaking with Shopify's resident database experts, they
    recommended me to not expose this feature in the public API.
    The reason why they don't recommend it, is that this kind of locking
    break multiplexing mechanisms like ProxySQL and can decrease the
    resiliency of the application.
    
    My original motivation was to remove a monkey patch in our application
    and since we are not planning to allow people to use that feature in our
    application anymore there is no reason to me expose this locking mechanism
    anymore in the framework.
    561fa1e1
    Revert "Add ActiveRecord::Base.connection.with_advisory_lock"
    Rafael Mendonça França authored
    This reverts commit 1ab4dbf8.
    
    After speaking with Shopify's resident database experts, they
    recommended me to not expose this feature in the public API.
    The reason why they don't recommend it, is that this kind of locking
    break multiplexing mechanisms like ProxySQL and can decrease the
    resiliency of the application.
    
    My original motivation was to remove a monkey patch in our application
    and since we are not planning to allow people to use that feature in our
    application anymore there is no reason to me expose this locking mechanism
    anymore in the framework.
Loading