Skip to content
  • Jean Boussier's avatar
    d917896f
    Enable verbose mode in test and report warnings as errors · d917896f
    Jean Boussier authored
    We recently let a few very easy to avoid warnings get merged.
    The root cause is that locally the test suite doesn't run in
    verbose mode unless you explictly pass `-w`.
    
    On CI warnings are enabled, but there is no reason to look at the
    build output unless something is failing. And even if one wanted
    to do that, that would be particularly work intensive since warnings
    may be specific to a Ruby version etc.
    
    Because of this I believe we should:
    
      - Always run the test suite with warnings enabled.
      - Raise an error if a warning is unexpected.
    
    We've been using this pattern for a long time at Shopify both in private
    and public repositories.
    d917896f
    Enable verbose mode in test and report warnings as errors
    Jean Boussier authored
    We recently let a few very easy to avoid warnings get merged.
    The root cause is that locally the test suite doesn't run in
    verbose mode unless you explictly pass `-w`.
    
    On CI warnings are enabled, but there is no reason to look at the
    build output unless something is failing. And even if one wanted
    to do that, that would be particularly work intensive since warnings
    may be specific to a Ruby version etc.
    
    Because of this I believe we should:
    
      - Always run the test suite with warnings enabled.
      - Raise an error if a warning is unexpected.
    
    We've been using this pattern for a long time at Shopify both in private
    and public repositories.
Loading