Skip to content
  • eileencodes's avatar
    935120fd
    Fix did you mean tests for ruby-trunk (3.2) · 935120fd
    eileencodes authored
    In
    https://github.com/ruby/ruby/commit/f075be3dcb4b82b89496d1820002bf3d80f653ef
    did_you_mean and error_highlight now use `detailed_message` over
    `message` to display errors.
    
    For cases where we are testing `message`, in 3.2 and above we need to
    test against `detailed_message` instead.
    
    As far as I can tell in a Rails console when these errors are raised the
    `detailed_message` is used so we shouldn't need to make other changes to
    Rails. The only case where this isn't true is in the Railties changes -
    we are explicitly formatting the did you mean message so we need to be
    sure to call `detailed_message` here.
    
    This fixes most of the failing tests for ruby-trunk.
    935120fd
    Fix did you mean tests for ruby-trunk (3.2)
    eileencodes authored
    In
    https://github.com/ruby/ruby/commit/f075be3dcb4b82b89496d1820002bf3d80f653ef
    did_you_mean and error_highlight now use `detailed_message` over
    `message` to display errors.
    
    For cases where we are testing `message`, in 3.2 and above we need to
    test against `detailed_message` instead.
    
    As far as I can tell in a Rails console when these errors are raised the
    `detailed_message` is used so we shouldn't need to make other changes to
    Rails. The only case where this isn't true is in the Railties changes -
    we are explicitly formatting the did you mean message so we need to be
    sure to call `detailed_message` here.
    
    This fixes most of the failing tests for ruby-trunk.
Loading