Skip to content
  • Alex Ghiculescu's avatar
    2d239ad9
    Clarify CI requirement in PR template [ci skip] · 2d239ad9
    Alex Ghiculescu authored
    You can't check if "CI is passing" until you create a PR, because for most people Buildkite will only run the build when a PR is created (It will run on branch push only if you push to a branch of the `rails/rails` repo, which only people with write access can do.). So we shouldn't tell people to wait for CI to pass before submitting a PR.
    
    This PR just tweaks the CI template to explain this in a comment so that people know to check back once CI has actually run.
    2d239ad9
    Clarify CI requirement in PR template [ci skip]
    Alex Ghiculescu authored
    You can't check if "CI is passing" until you create a PR, because for most people Buildkite will only run the build when a PR is created (It will run on branch push only if you push to a branch of the `rails/rails` repo, which only people with write access can do.). So we shouldn't tell people to wait for CI to pass before submitting a PR.
    
    This PR just tweaks the CI template to explain this in a comment so that people know to check back once CI has actually run.
Loading