Skip to content
  • Alex's avatar
    0a8e5374
    Simplify normalization of regexp test filters · 0a8e5374
    Alex authored
    
    
    Follow-up to #47942.
    
    This commit simplifies the normalization of regexp test filters.
    Instead of modifying a given regexp to match a union of whitespace and
    underscores, the regexp is unioned with the underscore-normalized
    version of itself.  This allows filters that include escaped spaces,
    such as `/foo\ bar/`.
    
    This commit also fixes `Rails::LineFiltering#run` such that
    normalization isn't reapplied for every test suite.  Thus
    `normalize_declarative_test_filter` is no longer required to be
    idempotent.
    
    Co-authored-by: default avatarJonathan Hefner <jonathan@hefner.pro>
    0a8e5374
    Simplify normalization of regexp test filters
    Alex authored
    
    
    Follow-up to #47942.
    
    This commit simplifies the normalization of regexp test filters.
    Instead of modifying a given regexp to match a union of whitespace and
    underscores, the regexp is unioned with the underscore-normalized
    version of itself.  This allows filters that include escaped spaces,
    such as `/foo\ bar/`.
    
    This commit also fixes `Rails::LineFiltering#run` such that
    normalization isn't reapplied for every test suite.  Thus
    `normalize_declarative_test_filter` is no longer required to be
    idempotent.
    
    Co-authored-by: default avatarJonathan Hefner <jonathan@hefner.pro>
Loading