Skip to content
  • eileencodes's avatar
    9766eb4a
    Fix tests for minitest 5.16 · 9766eb4a
    eileencodes authored
    
    
    In minitest/minitest@6e06ac9 minitest changed such that it now accepts
    `kwargs` instead of requiring kwargs to be shoved into the args array.
    This is a good change but required some updates to our test code to get
    the new version of minitest passing.
    
    Changes are as follows:
    
    1) Lock minitest to 5.15 for Ruby 2.7. We don't love this change but
    it's pretty difficult to get 2.7 and 3.0 to play nicely together with
    the new kwargs changes. Dropping 2.7 support isn't an option right
    now for Rails. This is safe because all of the code changes here are
    internal methods to Rails like assert_called_with. Applications
    shouldn't be consuming them as they are no-doc'd.
    2) Update the `assert_called_with` method to take any kwargs but also
    the returns kwarg.
    3) Update callers of `assert_called_with` to move the kwargs outside the
    args array.
    4) Update the message from marshaled exceptions. In 5.16 the exception
    message is "result not reported" instead of "Wrapped undumpable
    exception".
    
    Co-authored-by: default avatarMatthew Draper <matthew@trebex.net>
    9766eb4a
    Fix tests for minitest 5.16
    eileencodes authored
    
    
    In minitest/minitest@6e06ac9 minitest changed such that it now accepts
    `kwargs` instead of requiring kwargs to be shoved into the args array.
    This is a good change but required some updates to our test code to get
    the new version of minitest passing.
    
    Changes are as follows:
    
    1) Lock minitest to 5.15 for Ruby 2.7. We don't love this change but
    it's pretty difficult to get 2.7 and 3.0 to play nicely together with
    the new kwargs changes. Dropping 2.7 support isn't an option right
    now for Rails. This is safe because all of the code changes here are
    internal methods to Rails like assert_called_with. Applications
    shouldn't be consuming them as they are no-doc'd.
    2) Update the `assert_called_with` method to take any kwargs but also
    the returns kwarg.
    3) Update callers of `assert_called_with` to move the kwargs outside the
    args array.
    4) Update the message from marshaled exceptions. In 5.16 the exception
    message is "result not reported" instead of "Wrapped undumpable
    exception".
    
    Co-authored-by: default avatarMatthew Draper <matthew@trebex.net>
Loading