Skip to content
  • zzak's avatar
    bd4be496
    Fix MiniMagic::Image.mime_type deprecation in ASto test · bd4be496
    zzak authored
    ```
    [MiniMagick] MiniMagick::Image#mime_type has been deprecated, because it wasn't returning correct result for all formats ImageMagick supports. Unfortunately, returning the correct MIME type would be very slow, because it would require ImageMagick to read the whole file. It's better to use Marcel and MimeMagic gems, which are able to determine the MIME type just from the image header.
    ```
    
    This method is removed in v5 of `mini_magick` gem:
    
    > Removed deprecated Image#mime_type, as it wasn't accurate.
    > MIME type from file content should be determined either using Marcel
    > or MimeMagic, or mime-types or MiniMime using Image#type.
    
    Since we depend on it through `image_processing` gem
    (`mini_magick (>= 4.9.5, < 5)`), while work is being done in
    janko/image_processing#132 so sooner or later this test will fail.
    bd4be496
    Fix MiniMagic::Image.mime_type deprecation in ASto test
    zzak authored
    ```
    [MiniMagick] MiniMagick::Image#mime_type has been deprecated, because it wasn't returning correct result for all formats ImageMagick supports. Unfortunately, returning the correct MIME type would be very slow, because it would require ImageMagick to read the whole file. It's better to use Marcel and MimeMagic gems, which are able to determine the MIME type just from the image header.
    ```
    
    This method is removed in v5 of `mini_magick` gem:
    
    > Removed deprecated Image#mime_type, as it wasn't accurate.
    > MIME type from file content should be determined either using Marcel
    > or MimeMagic, or mime-types or MiniMime using Image#type.
    
    Since we depend on it through `image_processing` gem
    (`mini_magick (>= 4.9.5, < 5)`), while work is being done in
    janko/image_processing#132 so sooner or later this test will fail.
Loading