Skip to content
  • Olivier Lacan's avatar
    5a3b7a17
    Clarify how store_location_for modifies URIs (#4391) · 5a3b7a17
    Olivier Lacan authored
    This fairly straightforward refactor extracts the most obtuse
    portions of store_location_for into the following discrete
    private methods:
    - extract_path_from_location
    - remove_domain_from_uri
    - add_fragment_back_to_path
    
    This may seem like indirection but it was very unclear what
    operation was being performed on the location sent to
    store_location_for prior to this change.
    
    I considered documenting the behavior but the code seemed
    like a prime candidate for method extraction.
    5a3b7a17
    Clarify how store_location_for modifies URIs (#4391)
    Olivier Lacan authored
    This fairly straightforward refactor extracts the most obtuse
    portions of store_location_for into the following discrete
    private methods:
    - extract_path_from_location
    - remove_domain_from_uri
    - add_fragment_back_to_path
    
    This may seem like indirection but it was very unclear what
    operation was being performed on the location sent to
    store_location_for prior to this change.
    
    I considered documenting the behavior but the code seemed
    like a prime candidate for method extraction.
Loading