Skip to content
  • Carlos Antonio da Silva's avatar
    367ea427
    Refactor dirty tracking conditionals for different versions (#5575) · 367ea427
    Carlos Antonio da Silva authored
    We have an number of conditions due to how dirty tracking changed around
    Rails 5.1, that implement methods using one or another method call. I
    might need more of this for mongo upgrades based on an initial
    investigation, plus this makes the code really hard to reason about
    sometimes with these many conditionals.
    
    While I want to drop support for older versions of Rails soon, this
    centralization of dirty methods that are used by devise conditionally
    simplifies the usage considerably across the board, moves the version
    condition to a single place, and will make it easier to refactor later
    once we drop older Rails version by simply removing the `devise_*`
    versions of the methods, alongside the prefix on the method calls for
    the most part, since those methods follow the naming of the newer Rails
    versions.
    367ea427
    Refactor dirty tracking conditionals for different versions (#5575)
    Carlos Antonio da Silva authored
    We have an number of conditions due to how dirty tracking changed around
    Rails 5.1, that implement methods using one or another method call. I
    might need more of this for mongo upgrades based on an initial
    investigation, plus this makes the code really hard to reason about
    sometimes with these many conditionals.
    
    While I want to drop support for older versions of Rails soon, this
    centralization of dirty methods that are used by devise conditionally
    simplifies the usage considerably across the board, moves the version
    condition to a single place, and will make it easier to refactor later
    once we drop older Rails version by simply removing the `devise_*`
    versions of the methods, alongside the prefix on the method calls for
    the most part, since those methods follow the naming of the newer Rails
    versions.
Loading